Processor durability and processor parallelism #144
Open
novatechflow wants to merge 2 commits into
Open
Conversation
52803fe to
9e49edc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements #113 by removing an unnecessary
.indexdownload from the processor decode path instead of parallelizing two S3 reads where only one was actually used.It also fixes a PITR bug by making restore truncate the final segment at the requested cutoff and regenerate a matching
.index, rather than only restoring whole segments.While tracing that path, I also tightened PITR/restore behavior in storage so the final recovered segment can be truncated at the requested cutoff and a matching
.indexis regenerated.Changes
.indexin the SQL and Iceberg processor decoders.kfs/.indexpairing validation in discovery.indexafter truncationTesting
go test ./pkg/storage ./cmd/kafscale-cli -count=1 -timeout=120sgo test ./... -count=1 -timeout=120sinaddons/processors/sql-processorgo test ./... -count=1 -timeout=120sinaddons/processors/iceberg-processorChecklist