Improve handling of large values by inverse hyperbolic and trigonometric functions#2928
Open
antonwolfy wants to merge 12 commits into
Open
Improve handling of large values by inverse hyperbolic and trigonometric functions#2928antonwolfy wants to merge 12 commits into
antonwolfy wants to merge 12 commits into
Conversation
…x_math::cacos() function
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2928/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_54 ran successfully. |
Collaborator
should this be filed as an issue with DPC++ compiler? Since most implementations should have logic to prevent overflow/infs in such cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dpnp.tensor.acoshfunction was returning incorrect results (infinity) for complex numbers with large negative real parts (see #2924).The issue was caused by the threshold used
1/epsilonto decide when to switch from acos in SYCL's experimental complex extension (exprm_ns::acos()) to a log-based formula.The SYCL
exprm_ns::acos()returns incorrect results for large negative real parts, due to used formulaz + sqrt(z² - 1), which leads tolog(0) = -infinity.The PR proposes to changed the threshold from
1/epsilontosqrt(1/epsilon)/2for all inverse trig/hyperbolic functions. This is the precision loss point wheresqrt(z² ± 1)calculations become unstable.Also the PR reduces code duplication by creating shared
casinh(),casin(),catanh(),catan()functions in newcomplex_math.hppheader.