Skip to content

Add HtmlSerializer (Xerces-free) and comprehensive HtmlSerializerTest #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add HtmlSerializer (Xerces-free) and comprehensive HtmlSerializerTest #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aaa28a
Add HtmlSerializer (Xerces-free) and comprehensive HtmlSerializerTest
Copilot May 16, 2026
115ae7a
Address code review: simplify null check, remove blank line
Copilot May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/org/owasp/validator/html/scan/AbstractAntiSamyScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,18 @@ protected org.apache.xml.serialize.HTMLSerializer getHTMLSerializer(
return new ASHTMLSerializer(w, format, policy);
}

/**
* Returns a new {@link HtmlSerializer} configured for the current policy. This is the preferred
* serializer that does not depend on the deprecated Xerces
* {@code org.apache.xml.serialize.HTMLSerializer}.
*
* @param w the writer to serialize into
* @return a fully configured {@link HtmlSerializer}
*/
protected HtmlSerializer getHtmlSerializer(Writer w) {
return new HtmlSerializer(w, policy);
}

protected String trim(String original, String cleaned) {
if (cleaned.endsWith("\n")) {
if (!original.endsWith("\n")) {
Expand Down
6 changes: 1 addition & 5 deletions src/main/java/org/owasp/validator/html/scan/AntiSamyDOMScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,7 @@ public CleanResults scan(String html) throws ScanException {

StringWriter out = new StringWriter();

@SuppressWarnings("deprecation")
org.apache.xml.serialize.OutputFormat format = getOutputFormat();

//noinspection deprecation
org.apache.xml.serialize.HTMLSerializer serializer = getHTMLSerializer(out, format);
HtmlSerializer serializer = getHtmlSerializer(out);
serializer.serialize(dom);

/*
Expand Down
Loading