You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an additional use case of no plotting at all - only returning raw data. This is a very useful output so does need to remain, but I understand your statement in the issue #90 that it's bad practice to have conditional return types.
In fact, the fc.transform() function already has multiple return types, but that seems like a logical rule-break since a transformation to gcode or to a visualisation are clearly not going to return the same thing. However, I do see that tranforming to 'plot', and then having a second-condition for the returned object type can get confusing.
It may be best practice to move that functionality out of the 'plot' transform option. It could be a new standalone transform option of 'plot_data'. I mean that the user writes fc.transform(steps, 'plot_data') instead of the current approach of fc.transform(steps, 'plot', fc.GcodeControls(raw_data=True)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90, per this comment
controls.show = False(new behaviour)