Skip to content

fix: fix duplicate jaxb-core dependency#188

Merged
javier-godoy merged 2 commits into
masterfrom
issue-187
May 20, 2026
Merged

fix: fix duplicate jaxb-core dependency#188
javier-godoy merged 2 commits into
masterfrom
issue-187

Conversation

@mlopezFC
Copy link
Copy Markdown
Member

@mlopezFC mlopezFC commented Nov 25, 2025

Close #187

This PR resolves the duplicate jaxb-core-4.0.6.jar dependency issue that prevented users from upgrading to version 2.5.x when building WAR files with Gradle. The problem occurred because both docx4j-JAXB-ReferenceImpl and docx4j-JAXB-MOXy transitively included different implementations of the same JAXB core library under different Maven group IDs (org.glassfish.jaxb:jaxb-core and com.sun.xml.bind:jaxb-core).

The fix adds a Maven exclusion to the docx4j-JAXB-MOXy dependency, excluding com.sun.xml.bind:jaxb-core while keeping the GlassFish reference implementation. This change has been verified with a clean dependency tree, successful build, all unit tests passing and also manual testing of the demo.

Summary by CodeRabbit

  • Chores
    • Added additional ignore patterns to the repository to reduce clutter in IDEs and tooling.
    • Refined project dependency management by excluding a transitive runtime dependency from the build configuration to improve resolution and build stability.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 25, 2025

Walkthrough

This pull request adds two new entries (.eclipse and .vaadin) to .gitignore and adds a transitive dependency exclusion to pom.xml, excluding com.sun.xml.bind:jaxb-core from org.docx4j:docx4j-JAXB-MOXy to resolve duplicate jaxb-core implementations.

Changes

Build configuration

Layer / File(s) Summary
Maven dependency exclusion
pom.xml
Adds an <exclusions> block to org.docx4j:docx4j-JAXB-MOXy:11.5.0 removing the transitive com.sun.xml.bind:jaxb-core artifact from dependency resolution.

Git configuration

Layer / File(s) Summary
Repository ignore patterns
.gitignore
Adds .eclipse and .vaadin patterns to .gitignore to ignore IDE/project directories.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The changes directly address the linked issue #187 by excluding com.sun.xml.bind:jaxb-core from docx4j-JAXB-MOXy to eliminate the duplicate JAXB core dependency.
Out of Scope Changes check ✅ Passed The .gitignore additions are minor housekeeping and the pom.xml exclusion directly targets the stated issue; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: fix duplicate jaxb-core dependency' directly and specifically describes the main change in the PR, which adds a Maven exclusion to resolve the duplicate jaxb-core dependency issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-187

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation Bot moved this from To Do to In Progress in Flowing Code Addons Nov 26, 2025
Copy link
Copy Markdown
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but please take care of requested changes in comment #188 (review)

@paodb paodb self-assigned this May 20, 2026
@paodb paodb changed the title Fix duplicate jaxb-core dependency issue (#187) Fix duplicate jaxb-core dependency issue May 20, 2026
@paodb paodb changed the title Fix duplicate jaxb-core dependency issue Fix duplicate jaxb-core dependency May 20, 2026
mlopezFC added 2 commits May 20, 2026 12:08
Exclude jaxb-code transitive dependency to avoid duplicate problem.

Close #187
@sonarqubecloud
Copy link
Copy Markdown

@paodb paodb requested review from javier-godoy and paodb and removed request for javier-godoy May 20, 2026 15:11
@javier-godoy javier-godoy changed the title Fix duplicate jaxb-core dependency fix: fix duplicate jaxb-core dependency May 20, 2026
@javier-godoy javier-godoy merged commit 6db08bb into master May 20, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Pending release in Flowing Code Addons May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Jaxb-core-4.0.6.jar is a duplicate (when upgrading to Grid Exporter Addon 2.5.z)

3 participants