fix: fix duplicate jaxb-core dependency#188
Conversation
WalkthroughThis pull request adds two new entries ( ChangesBuild configuration
Git configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
javier-godoy
left a comment
There was a problem hiding this comment.
-
Please follow the Conventional Commits specification in the PR title
-
Don't include issue or PR numbers in the title
https://github.com/FlowingCode/AddonsInternal/blob/main/pr-process.md#conventions-on-pull-request-titles -
Use
Closes #187instead ofFixes #187
https://github.com/FlowingCode/DevelopmentConventions/blob/main/conventional-commits.md#5-footer
paodb
left a comment
There was a problem hiding this comment.
Changes LGTM but please take care of requested changes in comment #188 (review)
Exclude jaxb-code transitive dependency to avoid duplicate problem. Close #187
|



Close #187
This PR resolves the duplicate
jaxb-core-4.0.6.jardependency issue that prevented users from upgrading to version 2.5.x when building WAR files with Gradle. The problem occurred because bothdocx4j-JAXB-ReferenceImplanddocx4j-JAXB-MOXytransitively included different implementations of the same JAXB core library under different Maven group IDs (org.glassfish.jaxb:jaxb-coreandcom.sun.xml.bind:jaxb-core).The fix adds a Maven exclusion to the
docx4j-JAXB-MOXydependency, excludingcom.sun.xml.bind:jaxb-corewhile keeping the GlassFish reference implementation. This change has been verified with a clean dependency tree, successful build, all unit tests passing and also manual testing of the demo.Summary by CodeRabbit