Skip to content

fix: update overflow item selection state immediately on click #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paodb wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

fix: update overflow item selection state immediately on click #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/resources/META-INF/resources/frontend/src/fc-days-of-week-selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,15 @@
clonedButton._originalButton = originalButton;
clonedButton.removeAttribute("slot");
clonedButton.style.display = '';
clonedButton.addEventListener('click', ev => {
clonedButton.addEventListener('click', () => {
// Update server side button component state
clonedButton._originalButton.$server.toggleState();
if (clonedButton.getAttribute("theme")) {
clonedButton.removeAttribute("theme")
} else {
clonedButton.setAttribute("theme", "primary");
}
// Toggle only the "primary" token, preserving any other theme tokens
const themes = new Set((clonedButton.getAttribute('theme') || '').split(/\s+/).filter(Boolean));
themes.has('primary') ? themes.delete('primary') : themes.add('primary');
themes.size
? clonedButton.setAttribute('theme', [...themes].join(' '))

Check warning on line 208 in src/main/resources/META-INF/resources/frontend/src/fc-days-of-week-selector.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using `join()` for [...themes] will use Object's default stringification format ('[object Object]') when stringified. 


See more on https://sonarcloud.io/project/issues?id=FlowingCode_DayOfWeekSelectorAddon&issues=AZ4tQSpA9wBRmoDDwav-&open=AZ4tQSpA9wBRmoDDwav-&pullRequest=28
: clonedButton.removeAttribute('theme');
// Notify value change to DayOfWeekSelector component
this.dispatchEvent(new CustomEvent('change', {bubbles: true}));
});
Expand Down
Loading