feat: Use PhysicsScene2D.OverlapCollider in NetworkCollider2D#1042
Open
aaronkwan wants to merge 2 commits into
Open
feat: Use PhysicsScene2D.OverlapCollider in NetworkCollider2D#1042aaronkwan wants to merge 2 commits into
aaronkwan wants to merge 2 commits into
Conversation
Use PhysicsScene2D.OverlapCollider to allow NetworkCollider2D to work with any 2D collider shape. This removes the need for shape-specific checks. Note: A similar change is not possible for 3D colliders, as Unity's PhysicsScene does not provide a generic OverlapCollider method.
Use PhysicsScene2D.OverlapCollider to allow NetworkCollider2D to work with any 2D collider shape. This removes the need for shape-specific checks. Note: A similar change is not possible for 3D colliders, as Unity's PhysicsScene does not provide a generic OverlapCollider method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use PhysicsScene2D.OverlapCollider as a fallback to allow NetworkCollider2D to work with any 2D collider shape. Existing circle/box logic is kept because it uses
AdditionalSize.See discussion: #728
Note: A similar change is not possible for 3D colliders, as Unity's PhysicsScene does not provide a generic OverlapCollider method.