Add methods to manage channel fee policies and retrieve channels by outpoint#504
Open
markettes wants to merge 12 commits into
Open
Add methods to manage channel fee policies and retrieve channels by outpoint#504markettes wants to merge 12 commits into
markettes wants to merge 12 commits into
Conversation
…mplement it in LightningClientService
…age channel fee policies
…s to manage channel fee policies
…s in ChannelRepository and Lightning services
Jossec101
reviewed
May 12, 2026
Jossec101
reviewed
May 12, 2026
markettes
force-pushed
the
feat/set-channel-fee-policy
branch
from
cdc1049 to
bf09174
Compare
markettes
force-pushed
the
feat/set-channel-fee-policy
branch
from
d64426b to
a9e00a8
Compare
Jossec101
reviewed
May 18, 2026
|
|
||
| if (inboundBaseFeeMsat.HasValue && inboundFeeRatePpm.HasValue) | ||
| { | ||
| if (inboundBaseFeeMsat.Value > baseFeeMsat) |
Contributor
There was a problem hiding this comment.
Sorry I made a mistake, it has to be lower in absolute values, also are we handling that these values should be always negative?
Contributor
Author
There was a problem hiding this comment.
the part that inbound has to be ABS lower than outbound/general is not really accurate. It can be abs(normal)<abs(inbound) since inbound has nothing to do with outbound. Being inbound the channel x and y the outbound channel, the discound in inbound fees of channel x have to be lower than the outbound of channel y. Thats the correct constraint, hard to limit tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce methods for setting channel fee policies and retrieving channels by their outpoint. Implement unit tests to ensure functionality and correctness of these new features.