DataGrid - AI Assistant: Add abort confirmation dialog#33607
Open
Alyar666 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an abort confirmation flow to the DataGrid AI Assistant so that closing the chat while requests are in progress prompts the user before aborting ongoing work. It also formalizes ui.dialog.custom typings so internal code can reuse dialog option types, adds the required localization key, and introduces styling + Jest coverage for the new behavior.
Changes:
- Added a themed confirmation dialog factory (
createConfirmDialog) and wired it into the AI Assistant popuponHidinghook to prevent accidental aborts while processing. - Updated
ui/dialog.d.tsto exportBaseDialog/DialogParamsand typedcustom()to return a dialog object rather thanany. - Added a new localization string key across locales plus SCSS styling and Jest tests for the new dialog and view behavior.
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/ui/dialog.d.ts | Exposes dialog typings and narrows custom() return type. |
| packages/devextreme/js/localization/messages/ar.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/bg.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/ca.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/cs.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/da.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/de.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/el.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/en.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/es.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/fa.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/fi.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/fr.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/hu.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/it.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/ja.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/ko.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/lt.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/lv.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/nb.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/nl.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/pl.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/pt.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/ro.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/ru.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/sl.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/sv.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/tr.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/uk.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/vi.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/zh-tw.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/localization/messages/zh.json | Adds AI Assistant abort-confirm text key. |
| packages/devextreme/js/__internal/ui/dialog.ts | Switches to using exported dialog types (removes local duplicates). |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts | Adds confirmation dialog creation utility with theme-aware sizing/button styling. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/const.ts | Adds confirm-dialog CSS class + width constants. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Cancels popup hide while processing and shows the abort confirmation dialog. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts | Exposes isProcessing() to drive the confirmation condition. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/utils.test.ts | Adds unit tests for createConfirmDialog options/styling/width behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.test.ts | Adds tests for on-hiding cancellation and abort/hide behavior based on confirmation result. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_controller.test.ts | Adds tests for isProcessing() state transitions. |
| packages/devextreme-scss/scss/widgets/base/gridBase/_variables.scss | Adds a SCSS variable for confirm dialog button width. |
| packages/devextreme-scss/scss/widgets/base/gridBase/_index.scss | Styles confirm dialog buttons under the AI assistant confirm dialog class. |
Alyar666
force-pushed
the
datagrid_ai_assistant_confirm_message_26_1
branch
from
757a18e to
8a7960c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.