Skip to content

Fix runtime script-disk watcher gaps for manually created and first-use disk folders#62

Merged
rubensworks merged 5 commits into
master-1.20-ltsfrom
copilot/fix-external-script-sync-issue
May 16, 2026
Merged

Fix runtime script-disk watcher gaps for manually created and first-use disk folders#62
rubensworks merged 5 commits into
master-1.20-ltsfrom
copilot/fix-external-script-sync-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

  • Re-check GitHub Actions failures on base branch and this PR branch
  • Identify the remaining failing matrix jobs and exact failing tests from logs
  • Apply a robust, minimal fix for remaining watcher test flakiness
  • Run targeted tests repeatedly to validate the fix
  • Run full build validation
  • Run final validation tooling and reply to the new PR comment

Copilot AI changed the title [WIP] Fix external script edits not syncing until restart Fix runtime script-disk watcher gaps for manually created and first-use disk folders May 16, 2026
Copilot AI requested a review from rubensworks May 16, 2026 06:37
@rubensworks
Copy link
Copy Markdown
Member

@copilot CI in this PR fails. Please fix, and validate yourself after fixing and before finishing.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot CI in this PR fails. Please fix, and validate yourself after fixing and before finishing.

I fixed the CI failure in commit ccda308 by stabilizing the new watcher tests (eliminating timing races and increasing async wait tolerance). I validated locally with repeated targeted runs and a full ./gradlew build, all passing.

@rubensworks rubensworks marked this pull request as ready for review May 16, 2026 07:10
@rubensworks
Copy link
Copy Markdown
Member

@copilot Some builds in CI still fail. Please think this through, and properly fix.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot Some builds in CI still fail. Please think this through, and properly fix.

I pushed a deeper flake fix in 96e23e3: the watcher tests now retry external writes until synchronization is observed, which removes the remaining timing race seen in the Java 20 CI job. I revalidated with 5 repeated targeted test runs, a full ./gradlew build, and final validation checks.

@rubensworks rubensworks merged commit cb500e9 into master-1.20-lts May 16, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External script edits don't sync until restart when disk folder is manually created or first used at runtime

2 participants