More efficient check of references in save&restore#3805
Merged
Conversation
|
jacomago
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Recently added: annotation of save&restore snapshot and composite snapshots referenced in any composite snapshot. The implementation however is very inefficient as it generates queries to the service whenever JavaFX determines that the
TreeCellmust be re-rendered.This PR abandons the annotation strategy to instead disable the Delete menu item if references are found. This way the call to the service happens only when context menu is launched, and only for the selected node, so user will be able to determine if a snapshot or composite snapshot can be deleted before attempting the operation.
Testing:
Documentation: