Skip to content

[T3135] FIX: removed double point from "Sprache"#2095

Merged
Danielgergely merged 1 commit into
14.0from
T3135-german-translation-fix
Apr 21, 2026
Merged

[T3135] FIX: removed double point from "Sprache"#2095
Danielgergely merged 1 commit into
14.0from
T3135-german-translation-fix

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

No description provided.

@Danielgergely Danielgergely merged commit 08cee07 into 14.0 Apr 21, 2026
1 check passed
@Danielgergely Danielgergely deleted the T3135-german-translation-fix branch April 21, 2026 16:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the German translation for 'Language' by removing the trailing colon. Feedback indicates that this change may cause UI inconsistencies where the term is used as a label, suggesting that the source code should differentiate between selection values and labels to allow for context-specific translations.

#, python-format
msgid "Language"
msgstr "Sprache:"
msgstr "Sprache"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces a UI inconsistency. While removing the colon is correct for this msgid when used as a selection value (as seen in child_compassion.selection__compassion_child__major_course_study__language), it is also used as a label in project_description.py. Other labels from that context consistently have a colon appended in the German translation (e.g., msgid "Closest city" is translated as msgstr "Nächste Stadt:").

To resolve this ambiguity properly, the msgid for the label context should be differentiated from the value context in the source code (e.g., by using Language: for the label). This would allow for consistent translations for both contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant