London | May-2026-itp | Vitalii Kmit | Sprint 1 | Form Controls#1277
Open
Vitalii-code wants to merge 8 commits into
Open
London | May-2026-itp | Vitalii Kmit | Sprint 1 | Form Controls#1277Vitalii-code wants to merge 8 commits into
Vitalii-code wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Vitalii-code
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 16, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, please see my comments for where to improve further
|
|
||
| <!-- colours --> | ||
| <label for="color">Choose a color:</label> | ||
| <select id="color" name="color"> |
There was a problem hiding this comment.
If someone enters their name and email then presses enter to go to the next section, will they get a chance to pick a colour and size? How could you update the form to assist with this?
Author
There was a problem hiding this comment.
I have changed the code please see the last commit
LonMcGregor
added
Reviewed
Vitalii-code
added
the
Needs Review
LonMcGregor
reviewed
May 16, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
You figured it out, the placeholder is what i was looking for . good job!
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist