SSF-207 Deep-linking for view orders and view assigned pantries#176
SSF-207 Deep-linking for view orders and view assigned pantries#176Juwang110 wants to merge 1 commit into
Conversation
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
looks really great, everything seems to work. just some discussion points worth having i think
| const assignedPantries = await ApiClient.getVolunteerPantries( | ||
| Number(volunteerIdFromUrl), | ||
| ); | ||
| if (cancelled) return; |
There was a problem hiding this comment.
Just curious what the point of this cancelled variable is? We havent used this for any of our deeplinks yet, so why is this one different?
| </Badge> | ||
| </Table.Cell> | ||
| <Table.Cell textAlign="right"> | ||
| <Link |
There was a problem hiding this comment.
I wonder if we should disable this entirely if there are no orders for the pantry, as opposed to displaying it and navigating these but doing nothing (same would apply for the volunteer assigned pantries page too). thoughts?
| })); | ||
| } | ||
|
|
||
| navigate(ROUTES.ADMIN_ORDER_MANAGEMENT, { replace: true }); |
There was a problem hiding this comment.
One issue i forsee happening is that, if we navigate to a page with these filters set and then press the back arrow, all of our progress will go away (e.g.: i go into volunteer management, click on a volunteer's assigned pantries, click on view orders for one of those pantries, then back to volunteer's assigned pantries, the filter is reset). is this tradeoff better than just keeping the url there and not deleting it, in addition to keeping the filter checked? i feel like if these deeplinks are being clicked on, the user would likely not be looking to add more pantries to the filter
@Yurika-Kan curious to get your thoughts on this.
2 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-207
📝 Description
Various changes:
✔️ Verification
Verified deeplink functionality and design matched figma
🏕️ (Optional) Future Work / Notes
N/A