web: rename Inbox nav label to Sources and surface Notifs higher#78
Open
alex-fedotyev wants to merge 1 commit into
Open
web: rename Inbox nav label to Sources and surface Notifs higher#78alex-fedotyev wants to merge 1 commit into
alex-fedotyev wants to merge 1 commit into
Conversation
The /sources route shows raw sync-source feeds (Gmail, GitHub, Telegram). Labeling it "Inbox" in the nav rail collided with the notifications inbox concept that lives at /notifications, which made it harder to find. Renaming to "Sources" matches the route URL and removes the collision. Also move the Notifs item up next to Chat so the actionable surface sits at the top of the rail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sourcesnav rail label from "Inbox" to "Sources".The route shows raw sync-source feeds (Gmail, GitHub, Telegram)
and the URL already matches. The "Inbox" label collided with the
notifications inbox concept at
/notifications, which made therail harder to read at a glance.
at the top of the rail.
Test plan
cd web && npm run buildclean (vite + tsc).(the
isNotifscheck is keyed onpath === '/notifications',not the label or position).
to Chat, "Sources" lower with the Inbox icon, no other
changes.