Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (82.90%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 87.21% 86.26% -0.95%
==========================================
Files 48 51 +3
Lines 3276 3895 +619
Branches 593 724 +131
==========================================
+ Hits 2857 3360 +503
- Misses 329 415 +86
- Partials 90 120 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e contract bytecode
…ce tx.locktime correctness
- Fix some oversights where P2S contracts still try to access contract.address - Fix issue where successfully generated Bitauth URI is swallowed - Add FailingMockNetworkProvider to "test" network error behaviour - Fix failing spellcheck
Also update function.body location to be accurate
| return; | ||
| } | ||
|
|
||
| // TODO: Revisit this later, for now we allow loops to not have a require() at the end |
There was a problem hiding this comment.
Do we need to do this before launch?
There was a problem hiding this comment.
On thursday we should try to craft an example of where this might matter.
| @@ -0,0 +1,6 @@ | |||
| contract IntToByte() { | |||
There was a problem hiding this comment.
This test is marked as TODO still
There was a problem hiding this comment.
We should fix this on thursday.
|
We noticed that if there is only a single function parameter (and it is having its type enforced), we are adding a redundant We either fix it with a special case, or we can choose to use |
|
compiler docs are still missing the 2nd flag option and similarly in the release notes only has |
No description provided.