Fix Unsaved Changes Popup Shifting Page Elements#10
Merged
JManion32 merged 1 commit intoApr 17, 2026
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @JManion32! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we were using a React state (isDirty) to determine when to show the
Unsaved Changespopup on the profile page. This meant we were adding and removing the entire popup from the DOM. Since the content is centered on the page, this meant all elements were shifting whenever the user entered something into the input. This is bad UI. Imagine your paper moving every time you tried to write something. Not ideal.Now, the popup is determined by a ternary operator using the same state in the CSS classes for the popup div. This allows us to keep it on the page, and not impact the user experience.