Add QR Codes, Links, and tracking#6
Merged
Merged
Conversation
If the QR code returns the dest url, visits to that URL cannot be tracked. Use endpoint url instead.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @jgoldberger26! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
jgoldberger26
requested review from
YaoxuanZhang
and removed request for
shamikkarkhanis
Contributor
Author
|
I won't have time today to decouple users from links (the current implementation will allow unregistered users to have a null uid, otherwise it will be tracked), so I resolved merge conflicts and am opening this PR. @YaoxuanZhang if you want to use it for your edit Wednesday, feel free to approve and pull these changes into main. Otherwise I will add device tracking next week after we resubmit sprint 1. |
There was a problem hiding this comment.
Hi @jgoldberger26! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
It looks terrible this is going away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a link resolver under the /r/ api. The link resolver tracks users that pass through it, and can generate QR Codes to those links for easy sharing.
Would address https://linear.app/capyrpi/issue/CAPS-29/qr-code-generation-and-tracking
TODO still: