Skip to content

[BI-2843] - Select Sample Submission During Genotype Upload#467

Merged
jloux-brapi merged 2 commits into
developfrom
feature/BI-2843
May 7, 2026
Merged

[BI-2843] - Select Sample Submission During Genotype Upload#467
jloux-brapi merged 2 commits into
developfrom
feature/BI-2843

Conversation

@humsika
Copy link
Copy Markdown
Contributor

@humsika humsika commented May 7, 2026

Description

JIRA story card link: BI-2843

Updated the Genotypic Data import UI to use a sample submission-based flow instead of the previous experiment-based flow.

This change updates the genotype upload screen to:

  • load sample submissions for the active program
  • replace experiment selection with sample submission selection
  • update the genotype upload helper text to reference sample submissions
  • send the selected submissionId in the genotype upload request instead of experimentId

This keeps the BI-2843 frontend aligned with the submission-scoped upload workflow introduced by the dependent BI-2839 backend work.

Dependencies

bi-web: feature/BI-2843
bi-api: feature/BI-2839

Testing

Please verify the following in the UI:

  • Open Import Data > Genotypic Data
  • Confirm the screen shows sample submission-based instructional text
  • Confirm the selector is a plain dropdown for sample submissions
  • Confirm the selector is populated only with sample submissions for the active program
  • Attempt import without selecting a sample submission and confirm upload is blocked
  • Confirm the sample submission field is highlighted with validation error styling when import is attempted without a selection
  • Confirm the inline validation message Sample Submission Project Name is required is shown when import is attempted without a selection
  • Select a sample submission and a valid .vcf file, then confirm the upload request is built using the selected submissionId
  • Confirm the UI handles the no-sample-submission scenario with the intended empty-state / restricted upload behavior for the current implementation.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

@humsika humsika requested review from a team and jloux-brapi and removed request for a team May 7, 2026 18:11
Copy link
Copy Markdown
Contributor

@jloux-brapi jloux-brapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good!

@jloux-brapi jloux-brapi merged commit 6168013 into develop May 7, 2026
1 check passed
@jloux-brapi jloux-brapi deleted the feature/BI-2843 branch May 7, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants