Add Stack property to BarChartDataset and LineChartDataset#31
Open
berndlueneburg wants to merge 2 commits into
Open
Add Stack property to BarChartDataset and LineChartDataset#31berndlueneburg wants to merge 2 commits into
berndlueneburg wants to merge 2 commits into
Conversation
Added Stack property to BarChartDataset for dataset grouping.
Added Stack property to LineChartDataset for dataset grouping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
stackdataset property forBarChartDatasetandLineChartDataset— both files already carry a//stackplaceholder.stackis a standard Chart.js dataset option. On a stacked scale,datasets sharing the same
stackid are combined; datasets withdifferent ids render independently. This enables the documented
"Stacked Bar with Groups" chart, currently not expressible via the wrapper.
Changes
BarChartDataset: newstring? Stack(replaces the//Stackplaceholder)LineChartDataset: newstring? Stack(replaces the//stackplaceholder)Both follow the existing property pattern (
[AddedVersion],[DefaultValue(null)],[Description],[ParameterTypeName],[JsonIgnore(WhenWritingNull)]). Purely additive — no behaviour change,omitted from JSON when null.
[AddedVersion("1.2.3")]is a placeholder — happy to adjust to whateverthe next release version should be.