Export partition all#1741
Conversation
💡 Codex ReviewThis test relies on a fixed 15-second delay after ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6971178 to
a903c03
Compare
mkmkme
left a comment
There was a problem hiding this comment.
Looks good! I would definitely add this feature to the documentation though
| { | ||
| if (command.type != PartitionCommand::DROP_PARTITION && command.type != PartitionCommand::ATTACH_PARTITION && !(command.type == PartitionCommand::REPLACE_PARTITION && !command.replace)) | ||
| throw DB::Exception(ErrorCodes::SUPPORT_IS_DISABLED, "Only support DROP/DETACH/ATTACH PARTITION ALL currently"); | ||
| if (command.type != PartitionCommand::DROP_PARTITION |
There was a problem hiding this comment.
Nit: Seems irrelevant to the feature
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduce the export partition all command, which schedules exports for all partitions in a given table. Introduce a setting to control scheduling failure behavior
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: