25.8.16 Backport of #95597 - Fix zero‑copy unlock check before part dir move#1738
Open
mkmkme wants to merge 1 commit into
Open
25.8.16 Backport of #95597 - Fix zero‑copy unlock check before part dir move#1738mkmkme wants to merge 1 commit into
mkmkme wants to merge 1 commit into
Conversation
…ession_after_94262 Fix zero‑copy unlock check before part dir move
ianton-ru
approved these changes
May 6, 2026
zvonand
requested changes
May 20, 2026
Member
zvonand
left a comment
zvonand
left a comment
There was a problem hiding this comment.
this PR needs to be rebased onto stable-25.8 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix zero‑copy unlock check before part dir move
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix regression in (experimental) zero‑copy replication introduced by ClickHouse#94262 where shared parts could be deleted before other replicas finished fetching them (ClickHouse#95597 by @filimonov).
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: