Eemeli/enhancement/641/join us page update#653
Conversation
… layout and updated block composition
…uals, updated spacing and refined responsive styling
…/Join-Us-Page-Update
…and link styling, fixed image positioning, and corrected external link icon behavior across breakpoints
Rutjake
left a comment
There was a problem hiding this comment.
Great job on this PR altogether. Here are a few global points and findings from the review:
-
English Translation: I noticed that the English translation is currently missing. Do you need help with getting the translation, or are you planning to add it yourself?
-
Tablet Layout: On tablet screens, the texts don't seem to align/center quite right. Could you double-check the responsiveness for tablet breakpoints?
-
Figma Error (Internal Links): There is actually a mistake made by the designers in Figma. These are internal links, so they should not open in a new tab, and they should not have the "open in new tab" icon. Could you change them to open in the same tab and remove the icon?
Let me know your thoughts on these!
iPad:
| makeRedditBlock, | ||
| makeTeachersBlock, | ||
| makeDuunitoriBlock, | ||
| makeGetInTouchAndFollowBlock, |
There was a problem hiding this comment.
I see you are following the existing pattern from makeJoinUsBlocks.ts, which is great for consistency!
However, some of these names are getting quite long. To make the code a bit cleaner and easier to read, we could shorten them slightly by removing redundant words like "Block" (since the file name already indicates these are blocks).
What do you think about these slightly shorter alternatives?
makeGetInTouchAndFollowBlock -> makeContactAndFollow (or makeGetInTouchAndFollow)
makeCommunityAndOpportunitiesBlock -> makeCommunityAndOpportunities
makeEducationProfessionalsBlock -> makeEducationProfessionals
There was a problem hiding this comment.
Good job keeping the mock data updated here!
Just as a heads-up for the future: we actually don't use Storybook anymore, and the general guideline has been to remove these .stories files when we come across them.
However, it's really nice to see that you took the time to keep everything consistent and working anyway. For this PR, we can leave it as is (or you can delete the file if you want to clean it up now), but going forward, feel free to just delete the Storybook files!
📄 Pull Request Overview
Closes #641
🔧 Changes Made
Updated the Join Us page blocks with improved responsive layouts, refined mobile typography, corrected link and external icon behavior, and added the news page link.
Cleaned up unused block configurations and improved responsive styling logic for desktop, tablet, and mobile breakpoints.
✅ Checklist Before Submission
console.log()or other debugging statements are left. ✅📝 Additional Information
Provide any additional context or information that reviewers may need to know: