Skip to content

Eemeli/enhancement/641/join us page update#653

Open
EemeliJ wants to merge 10 commits into
devfrom
Eemeli/enhancement/641/Join-Us-Page-Update
Open

Eemeli/enhancement/641/join us page update#653
EemeliJ wants to merge 10 commits into
devfrom
Eemeli/enhancement/641/Join-Us-Page-Update

Conversation

@EemeliJ
Copy link
Copy Markdown
Contributor

@EemeliJ EemeliJ commented May 17, 2026

📄 Pull Request Overview

Closes #641

🔧 Changes Made

  1. Updated the Join Us page blocks with improved responsive layouts, refined mobile typography, corrected link and external icon behavior, and added the news page link.

  2. Cleaned up unused block configurations and improved responsive styling logic for desktop, tablet, and mobile breakpoints.


Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected. ✅
  • JSDoc: I have added or updated JSDoc comments for all relevant code. ✅
  • Debugging: No console.log() or other debugging statements are left. ✅
  • Clean Code: Removed commented-out or unnecessary code. ✅
  • Tests: Added new tests or updated existing ones for the changes made. ✅
  • Documentation: Documentation has been updated (if applicable). ✅

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots:
joinus1 joinus2 joinus3
  • Dependencies: No new dependencies were added.
  • Known Issues: No known issues at the moment.

Copy link
Copy Markdown
Contributor

@Rutjake Rutjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this PR altogether. Here are a few global points and findings from the review:

  • English Translation: I noticed that the English translation is currently missing. Do you need help with getting the translation, or are you planning to add it yourself?

  • Tablet Layout: On tablet screens, the texts don't seem to align/center quite right. Could you double-check the responsiveness for tablet breakpoints?

  • Figma Error (Internal Links): There is actually a mistake made by the designers in Figma. These are internal links, so they should not open in a new tab, and they should not have the "open in new tab" icon. Could you change them to open in the same tab and remove the icon?

Let me know your thoughts on these!

Image

iPad:

Image Image

makeRedditBlock,
makeTeachersBlock,
makeDuunitoriBlock,
makeGetInTouchAndFollowBlock,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are following the existing pattern from makeJoinUsBlocks.ts, which is great for consistency!

However, some of these names are getting quite long. To make the code a bit cleaner and easier to read, we could shorten them slightly by removing redundant words like "Block" (since the file name already indicates these are blocks).

What do you think about these slightly shorter alternatives?

makeGetInTouchAndFollowBlock -> makeContactAndFollow (or makeGetInTouchAndFollow)

makeCommunityAndOpportunitiesBlock -> makeCommunityAndOpportunities

makeEducationProfessionalsBlock -> makeEducationProfessionals

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job keeping the mock data updated here!

Just as a heads-up for the future: we actually don't use Storybook anymore, and the general guideline has been to remove these .stories files when we come across them.

However, it's really nice to see that you took the time to keep everything consistent and working anyway. For this PR, we can leave it as is (or you can delete the file if you want to clean it up now), but going forward, feel free to just delete the Storybook files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants