Fix Issue #186: Orphan Plots#216
Open
Cinnazeyy wants to merge 2 commits into
Open
Conversation
Zoriot
requested changes
May 13, 2026
Member
Zoriot
left a comment
Zoriot
left a comment
There was a problem hiding this comment.
Please fix the Codacy issue, other then that LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using undoreview, it can happen that a builder already filled up all slots again after the review was completed, meaning undoreview cannot set the plot to a slot again, resulting in an orphan plot that is assigned to a builder but not a slot.
This PR changes how the undoreview() method treats this edgecase by simply returning true instead of false.
This will still cause an orphan, but not fail the /undoreview command early and result in the orphans at least being accessible via the player plots menu.
Additionally, this PR also adds a check for whenever a slot is getting freed up, to assign the next orphan instead.