Disable ensureContinuousROF when calibration data is requested#15404
Merged
Conversation
By default avoid ROFs modifications in ensureContinuousROF when the --enable-calib-data is active: calibration runs do not respect declared number of ROFs and inject bogus orbits. There is still a possibility to enforce ensureContinuousROF with eventual rectifyDigits/Clusters in case the calibration data is requested via --enforce-continuous-rof-with-calib (beware that this may lead to a desynchronization between the calibration data container and ROFs/digits). Also, for backward compatibility, option --disable-rectify-continuous-rof will disable the calling of rectifyDigits/Clusters after eventual ensureContinuousROF.
Collaborator
Author
f3sch
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, avoid ROFs vector modifications in
ensureContinuousROFwhen the--enable-calib-datais active:calibration runs do not respect the declared number of ROFs and inject bogus orbits.
There is still a possibility to enforce the
ensureContinuousROFwith eventual rectifyDigits/Clusters in casethe calibration data is requested via
--enforce-continuous-rof-with-calib(beware that this may lead to a desynchronization between the calibration data container and ROFs/digits).
Also, for backward compatibility, the option
--disable-rectify-continuous-rofallows the disabling of the calling of rectifyDigits/Clusters after eventualensureContinuousROF.