Skip to content

plugin-wasm: namespaced_kind core:: reserved-prefix branch is unreachable #470

@staging-devin-ai-integration

Description

Summary

namespaced_kind checks kind.contains("::") before kind.starts_with("core::"), so any value containing the namespace separator is rejected by the first guard with the error reserved for namespace prefixes, and the core::-specific branch is never reached. This means the documented core::-specific error path cannot fire for any input that actually starts with core::.

Pinned by tests::namespaced_kind_rejects_reserved_core_prefix in https://github.com/streamer45/streamkit/blob/main/crates/plugin-wasm/src/lib.rs.

Suggested fix

Either:

  • Reorder the checks so starts_with("core::") runs first and returns a distinct error, or
  • Remove the dead core:: branch.

Once fixed, update namespaced_kind_rejects_reserved_core_prefix to assert the new (intended) error message.

Discovered by

PR #467 (Phase 3 coverage initiative — Stream B).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions