CRITICAL: Connection leak on server shutdown

[poyrazK]

Why is this an issue?

In include/network/server.hpp:221-242:

while (running_.load()) {
    // recv loop
}
close(client_fd);  // May not be reached if stop() called

Client sockets may not be closed properly on shutdown.

What is causing it?

No clean shutdown protocol.

How can it be solved?

Use proper shutdown protocol or condition variable.

Category

• Small
• Medium
• Large
• Critical

Severity

• Low
• Medium
• High
• Critical