Skip to content

Why is the code so rough? #115

@MaeThird

Description

@MaeThird

As a financial product, could you please enforce better code quality? I tried it briefly and immediately ran into several frustrating issues:

  1. Inconsistent units: For example, the live logs show timestamps in both milliseconds and seconds. Order { order_id: "xxx", client_order_id: "xxx", market_index: 1, owner_account_index: xxx, remaining_base_amount: "0.00020", side: "", is_ask: true, price: "93000.0", base_price: 930000, filled_base_amount: "0.00000", status: "open", nonce: xxx, order_expiry: 1771303769099, created_at: 1768884474, timestamp: 1768884374 }
  2. Non-standard authentication: In http the authorization header is set as .header(AUTHORIZATION, format!("{}", auth_token)) instead of the common convention .header(AUTHORIZATION, format!("Bearer {}", auth_token)). And in WS the Pong frame is not regular pong but "type": "pong"
  3. Missing callbacks: There’s no callback at all for orders like canceled-post-only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions